Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kotlin] fix invalid code when allOf is used #12594

Merged
merged 2 commits into from
Jun 22, 2022
Merged

[Kotlin] fix invalid code when allOf is used #12594

merged 2 commits into from
Jun 22, 2022

Conversation

etremblay
Copy link
Contributor

@etremblay etremblay commented Jun 14, 2022 •
edited
Loading

#10792

I just backported the fix for updateModelForObject from CSharpNetCoreClientCodegen

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@etremblay etremblay mentioned this pull request Jun 14, 2022
Open
6 tasks
@etremblay etremblay force-pushed the issue-10792-kotlin-allOf branch from d9b8486 to 4d18245 Compare June 14, 2022 12:19
@etremblay etremblay changed the title Step to reproduces [BUG] Kotlin generator produces invalid code when allOf is used Jun 14, 2022
etremblay
etremblay commented Jun 14, 2022
View reviewed changes
.../petstore/kotlin-allOff-discriminator/src/main/kotlin/org/openapitools/client/models/Bird.kt
@Json(name = "featherType")
val featherType: kotlin.String

) : Animal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this fix, this produced Animal() whish fail because Animal does not hava a constructor.

@etremblay etremblay marked this pull request as ready for review June 14, 2022 13:16
@etremblay
Copy link
Contributor Author

@jimschubert (2017/09) heart, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@etremblay etremblay changed the title [BUG] Kotlin generator produces invalid code when allOf is used [BUG] Issue 10792 Kotlin generator produces invalid code when allOf is used Jun 14, 2022
@etremblay etremblay mentioned this pull request Jun 14, 2022
Merged
4brunu
4brunu approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@4brunu 4brunu merged commit c38d825 into OpenAPITools:master Jun 22, 2022
@etremblay etremblay deleted the issue-10792-kotlin-allOf branch June 23, 2022 00:37
@wing328 wing328 added this to the 6.0.1 milestone Jul 2, 2022
@wing328 wing328 changed the title [BUG] Issue 10792 Kotlin generator produces invalid code when allOf is used [Kotlin generator] fix invalid code when allOf is used Jul 2, 2022
@wing328 wing328 changed the title [Kotlin generator] fix invalid code when allOf is used [Kotlin] fix invalid code when allOf is used Jul 2, 2022
@gesellix gesellix mentioned this pull request Jul 21, 2022
Merged
@meriouma meriouma mentioned this pull request Aug 30, 2022
Merged
meriouma added a commit to kronostechnologies/standards that referenced this pull request Sep 8, 2022
@meriouma
chore(gradle/openapi-sdk): update to OpenAPI 6.0.1 and update Microna…
48d7a0a 
…ut codegen (#147)

Lié à
kronostechnologies/micronaut-project-openapi-generator#30

J'ai supprimé le patch pour le générateur kotlin, c'est released dans
6.0.1. (OpenAPITools/openapi-generator#12594)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4brunu 4brunu 4brunu approved these changes

Assignees
No one assigned
Labels
Client: Kotlin Issue: Bug Server: Kotlin
Projects
None yet
Milestone
6.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@etremblay @4brunu @wing328